Duplicate attributes in Patch request

This is not valid JSON, since the property is duplicated, so I would expect an error using the Base message "PropertyDuplicate" or an invalid JSON message "InvalidJSON". You certainly should not accept the "last" value regardless, as JSON payloads are not ordered (so even if it was valid, you can't know which was the "last" value).

Jeff

Hi Jeff,
If user is trying to patch same value, do we need to give 400 bad request or it can vary based on service implementation(URI specific)?

Assume user is giving patch request for Integer property  with same value in request body(already testvalue is 1)


{

testvalue:1
}

I'm unable to find standard message registry from redfish.dmtf.org/registries/Base.1.14.0.json, please add your comments

Thanks,
Mani

Hi Jeff,
Thanks for reply. In this case do we need to update etag also if we patch with same value or just simply give 200 with success message and not update etag
Assum if we have some constraint of updating same value, can we give bad request?

Thanks,
Mani

Thanks for reply.

Assume if we have some constraint of updating same value for some resources, can we give bad request or needs to return 200 success message for all cases?



Thanks,

Mani

Hi Jeff,
As per The JavaScript Object Notation (JSON) Data Interchange Format

 www.rfc-editor.org/rfc/rfc8259#section-4


An object whose names are all unique is interoperable in the sense

that all software implementations receiving that object will agree on

the name-value mappings. When the names within an object are not

unique, the behavior of software that receives such an object is

unpredictable. Many implementations report the last name/value pair

only. Other implementations report an error or fail to parse the

object, and some implementations report all of the name/value pairs,

including duplicates

It can be implementation specific and we can take last value for duplicated attributes instead of returning bad request
{

testvalue:1,

testvalue:2,

testvalue:3

}

Assume we have lot of attributes in request body and comparing for duplicate attribute may take time , some json libraries won't support for finding duplicate attributes.

Please confirm whether we need to give "PropertyDuplicate" /an invalid JSON message "InvalidJSON" or take last value and process request

Thanks,
Mani

Hi Jeff,
Do we have any further update on this? Whether implementation can take last value of Attributes if duplicated, please confirm

Thanks,
Mani

If your JSON processor simply crashes because of the duplicate properties, you can return InvalidJSON; that's good enough - if json processor takes last name/value pair(without detect/crashes/return error) as per RFC, it needs to be allowed. Since user only giving request and using same attribute, service can process request instead of throwing error since user needs to give request again

Thanks,
Mani