BIOS attribute registry

ratagupt
Guppy

Posts: 87

BIOS attribute registry Mar 23, 2021 3:34:28 GMT

Quote

Post by ratagupt on Mar 23, 2021 3:34:28 GMT

BIOS attribute Registry:

OpenBMC is trying to implement the BIOS attribute Registry where we have hardcoded the "Name" and the "ID" property of the BIOS attribute registry.

Do we see a problem when different company start using this code and all might have the same Name and ID property for the BIOS attribute registry but they would be having different available attributes.

eg:

IBM Machine Bios Attribute registry:(Following data is just for an example)

[rgupta@localhost ~]$ curl -k -H "X-Auth-Token:$bmc_token" -X GET https://${BMC}/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry
{
"@odata.id": "/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry",
"@odata.type": "#AttributeRegistry.v1_3_2.AttributeRegistry",
"Id": "BiosAttributeRegistry",
"Language": "en",
"Name": "Bios Attribute Registry",
"OwningEntity": "OpenBMC",
"RegistryEntries": {
"Attributes": [
{
"AttributeName": "ibm_bios_1",
"CurrentValue": "Disabled",
"DefaultValue": "Disabled",
"DisplayName": "ibm_bios_1",
"HelpText": "Help text 1",
"MenuPath": "",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"OneOf": "Disabled"
},
{
"OneOf": "Enabled"
}
]
},
{
"AttributeName": "ibm_bios_2",
"CurrentValue": "test",
"DefaultValue": "test",
"DisplayName": "ibm_bios_2",
"HelpText": "test",
"MenuPath": "",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"OneOf": "Disabled"
},
{
"OneOf": "Enabled"
},
{
"OneOf": "test"
},
{
"OneOf": "test1"
}
]
},

Example Say Arm Machine reports the BIOS registry as following

}[rgupta@localhost ~]$ curl -k -H "X-Auth-Token:$bmc_token" -X GET https://${BMC}/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry
{
"@odata.id": "/redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry",
"@odata.type": "#AttributeRegistry.v1_3_2.AttributeRegistry",
"Id": "BiosAttributeRegistry",
"Language": "en",
"Name": "Bios Attribute Registry",
"OwningEntity": "OpenBMC",
"RegistryEntries": {
"Attributes": [
{
"AttributeName": "Arm_Bios_1",
"CurrentValue": "Disabled",
"DefaultValue": "Disabled",
"DisplayName": "Arm_Bios_1",
"HelpText": "Test",
"MenuPath": "",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"OneOf": "Disabled"
},
{
"OneOf": "Enabled"
}
]
},
{
"AttributeName": "Arm_Bios_2",
"CurrentValue": "Test",
"DefaultValue": "Test",
"DisplayName": "Arm_Bios_2",
"HelpText": "Arm_Bios_2",
"MenuPath": "",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"OneOf": "Disabled"
},
{
"OneOf": "Enabled"
},
{
"OneOf": "Test"
},
{
"OneOf": "Test1"
}
]
},

In both the examples above the Name and id of the BIOS attribute registry is same however the attributes are different, Do we see a issue in that?

Ratan

Last Edit: Mar 23, 2021 3:36:39 GMT by ratagupt

jautor
Administrator

Posts: 502

BIOS attribute registry Mar 23, 2021 23:52:50 GMT

Quote

Post by jautor on Mar 23, 2021 23:52:50 GMT

You should not be reporting two different BIOS message registries with the same name. The "Id" value, if the registry is included with the service, should match the "AttributeRegistry" property in the Bios resource that gives the registry name - and that should be different for two products with dissimilar BIOS attributes.

We're going to update the specification to call out that OEM-defined registries should have unique names to differentiate between vendors and between products. So for example, your two examples might be named "IBM_BiosRegistry_Power8" and "IBM_BiosRegistry_Arm" (although I would expect that those name are still too generic).

Jeff

ratagupt Guppy Posts: 87	BIOS attribute registry Apr 20, 2021 13:29:34 GMT Quote Select Post Deselect Post Link to Post Back to Top Post by ratagupt on Apr 20, 2021 13:29:34 GMT Thanks Jeff, What about the owning entity? Would that be same or it should be different.

jautor Administrator Posts: 502	BIOS attribute registry Apr 20, 2021 16:41:45 GMT Quote Select Post Deselect Post Link to Post Back to Top Post by jautor on Apr 20, 2021 16:41:45 GMT Apr 20, 2021 13:29:34 GMT ratagupt said: Thanks Jeff, What about the owning entity? Would that be same or it should be different. I would expect `OwningEntity` to be the same for all registries published by the same organization or company.

Post by ratagupt on Mar 23, 2021 3:34:28 GMT

Post by jautor on Mar 23, 2021 23:52:50 GMT

Post by ratagupt on Apr 20, 2021 13:29:34 GMT

Post by jautor on Apr 20, 2021 16:41:45 GMT