|
Post by reshma on Apr 6, 2023 13:25:45 GMT
Hi, I have been adding new property in TelemetryService URI, I have taken reference of the structure from the Guide - www.dmtf.org/sites/default/files/standards/documents/DSP2046_2022.3.pdfand added " SupportedCollectionFunctions" property and i ran validator, it is successful, But when i rename the Property as " CollectionFunctions" , we are supposed to show error for the same in validator tool, Please find the message in the report generated, As per the Schema, the value in the table for Property " CollectionFunction" should be failing(as the property name is invalid ).Is my understanding is right? Please comment on the same. Thanks.
|
|
|
Post by mraineri on Apr 6, 2023 13:47:36 GMT
Yes, there is an error shown below in the red text block, but it should also call out FAIL in the table of properties. Please file an issue on GitHub so we can track this.
|
|
|
Post by jautor on Apr 6, 2023 13:52:48 GMT
So it is flagging that as an error, with the messages at the bottom of the report in your image - the "ERROR - CollectionFunction is not defined". But it is not showing that error in-line for the property itself. This may be due to array property handling (which has a different code path), or, it may be a result of the tool actually matching the "CollectionFunction" to the correct "SupportedCollectionFunctions" name. The tool attempts to test against simple typographical errors in property names to do as much testing as possible. But it will still report those as errors. Could you try renaming "CollectionFunction" to something very different, like "FluffyBunny" and see what the report shows? Either way, please open an issue on GitHub for the tool, as while it is properly detecting the error, I agree that should be reported in the table and not just as a message at the bottom of the report. github.com/DMTF/Redfish-Service-ValidatorThanks, Jeff
|
|