|
Post by lukaszpl on Dec 13, 2023 14:55:40 GMT
Hello, Recently I've started using an Interop-Validator. I'm going to recommend using of this tool inside my organization, but at this moment I see a kind of limitation(?), bug(?)... In test report I can see that unexisting resources/properties that are 'Recommended' or 'IfImplemented' have a status: PASS. It gives a false view on the status of service implementation. Also, it requires additional tester's work to ensure which results are 'true' PASS. From my perspective, if the object is not Mandatory and does not exist, then test should has a status: Not Applicable (NA). Example: And the second scenario...
it is related with a validation of Read/Write properties. I see in the tool's helper an information, that 'writecheck' is not implemented. I understand why you have decided to not implement that. But I don't understand why InterOp still tries to validate both (Read/Write) properties... 'Read' is a default value - so if resource/property exists (we are able to read that), why we do a dobule check? I think that tests for "ReadWrite" property should have a special status in the report, for example: Not Applicable (NA), or should be removed. Example: Cheers, Lukasz
|
|
|
Post by jautor on Dec 13, 2023 15:41:50 GMT
Hello, Recently I've started using an Interop-Validator. I'm going to recommend using of this tool inside my organization, but at this moment I see a kind of limitation(?), bug(?)... In test report I can see that unexisting resources/properties that are 'Recommended' or 'IfImplemented' have a status: PASS. It gives a false view on the status of service implementation. Also, it requires additional tester's work to ensure which results are 'true' PASS. From my perspective, if the object is not Mandatory and does not exist, then test should has a status: Not Applicable (NA). Good suggestion. So change that green "PASS" column to white (don't want to flag these as warnings/errors, obviously) with probably separate text for "not tested / not implemented" and "verify implementation" (for IF-Implemented cases where we can't tell if the property is required or not). Please open an issue on GitHub so that it can be tracked and assigned - and pull requests to make improvements like this are always welcome! That's another good suggestion - please open an issue for that, too! That second test line was probably added to call out the specific write requirement. But you're correct that it effectively gives the same information twice, and so it should collapse those into one line. There are relatively new payload annotations defined in Redfish for the service to indicate which properties it has implemented as Read/Write (@redfish.WriteableProperties) that will help the tool provide some more information about Read/Write properties in the future... Jeff
|
|
|
Post by lukaszpl on Dec 18, 2023 13:27:19 GMT
|
|
|
Post by jautor on Dec 18, 2023 17:12:46 GMT
Awesome, thanks!
Jeff
|
|
|
Post by karinamw on Dec 21, 2023 9:28:49 GMT
|
|